Make clicking on a match select it on close-on-click (Fixes #149) #250
Conversation
…g#149) Modify `PluginMatch` box to handle GestureClick and claim the event, manually selecting the row. Then also output a `Clicked` event, which is passed on to the main app events. On this event, if `close-on-click` is true, do perform the `Select` action, picking the item and running its result. This changes the behaviour (for close-on-click=true) on clicking menu items, selecting them instead of just closing the application.
|
"And if there would be a way to make mouse bindings configurable in a way similar to how keybinds work now." Yea this would probably be best - would probably want another action for "PickRow" as well, to mark a row as currently selected. Binding the mouse buttons as keybinds did not work (even when they were accepted as correctly spelled). |
|
Yeah it won't work through the existing keybind config, it would require it's own config entry. This would probably mean having another action type for mouse stuff (something like |
|
Something like this instead? |
fixerer
force-pushed
the
make-matches-click-selectable
branch
from
29d8543 to
d6db78a
Compare
| Select, | ||
| Up, | ||
| Down, | ||
| Nop, |
There was a problem hiding this comment.
What's the point of having a Nop action?
| pub enum PluginBoxOutput { | ||
| MatchesLoaded, | ||
| RowSelected(<PluginBox as FactoryComponent>::Index), | ||
| MouseAction( |
There was a problem hiding this comment.
This is complex enough where it could be structified in the enum, as in:
MouseAction {
button: MouseButton,
...
}| .find(|mousebind| mousebind.button == button) | ||
| { | ||
| // Potentially select row | ||
| match action { |
There was a problem hiding this comment.
This kind of preprocessing of actions feels a bit ugly, I'd prefer if there was a general enum for mouse actions/events as a part of AppMsg, so that the mouse bindings could be extended to be the way close on click works is that it's just a mouse binding. And maybe deprecating that option as well.
In practice the mouse action part of AppMsg would contain all the different kinds of mouse actions/events that different callbacks will produce, and then the handler for the mouse actions specifically can do the required preprocessing before sending another action, if necessary/applicable.
Modify
PluginMatchbox to handle GestureClick and claim the event, manually selecting the row. Then also output aClickedevent, which is passed on to the main app events.On this event, if
close-on-clickis true, do perform theSelectaction, picking the item and running its result.This changes the behaviour (for close-on-click=true) on clicking menu items, selecting them instead of just closing the application.